Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project fails to reconfigure with '-DHydrogen_ENABLE_TESTING=ON' #140

Closed
yurivict opened this issue Dec 1, 2022 · 2 comments
Closed

Project fails to reconfigure with '-DHydrogen_ENABLE_TESTING=ON' #140

yurivict opened this issue Dec 1, 2022 · 2 comments

Comments

@yurivict
Copy link

yurivict commented Dec 1, 2022

I first build with -DHydrogen_ENABLE_TESTING=OFF - it succeeds.
Then I reconfigure it with ``````-DHydrogen_ENABLE_TESTING=ON``` in order to build and run tests.
This fails:

===>  Testing for hydrogen-linear-algebra-1.5.1.29
fatal: ambiguous argument 'hydrogen': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
-- Using __restrict__ keyword.
-- Found LAPACK: /usr/local/lib/libopenblas.so;-lpthread;-lm;-ldl
-- Using BLAS with trailing underscore.
-- Using LAPACK with trailing underscore.
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING

Most cmake-based projects are able to reconfigure with tests and run tests after build then.

It also isn't clear what make target runs tests. The README doesn't say anything about this.

@benson31
Copy link
Collaborator

benson31 commented Dec 5, 2022

I'm not able to reproduce this.

$ ninja
[167/167] Creating library symlink libHydrogen_CXX.so
$ cmake -DHydrogen_ENABLE_TESTING=ON ..
-- Found Aluminum@1.0.0: /path/to/aluminum/lib64/cmake/aluminum
-- Aluminum detected with NCCL2 backend support.
-- Aluminum detected with HostTransfer backend support.
-- Using __restrict__ keyword.
-- Found LAPACK: /usr/lib64/liblapack.so;/usr/lib64/libblas.so
-- Using BLAS with trailing underscore.
-- Using LAPACK with trailing underscore.
-- Configuring done
-- Generating done
-- Build files have been written to: /path/to/hydrogen-clean/build
$  ninja
[44/44] Linking CXX executable tests/Gemm_Suite

The tests are not well-maintained vis-a-vis the CMake integration. In particular, they might hang and/or not run at all. But the target is test (the default for CTest) if you want to try.

@yurivict
Copy link
Author

Tests build fine now - some scripting errors were to blame.

Thank you for your help.

@yurivict yurivict closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants