New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RAJA_COMPILER_XXX with compiler-specific defines #140

Closed

davidbeckingsale opened this issue Oct 27, 2016 · 3 comments

Labels

API/usability task

Member

davidbeckingsale commented Oct 27, 2016

Don't detect and hardcode the compiler in CMake, since these defines are used in headers by the user code.

This subsumes issue #102

davidbeckingsale mentioned this issue

Ensure RAJA_COMPILER_XXXX always matches RAJA_COMPILER_${CMAKE_CXX_COMPILER_ID} #102

Closed

davidbeckingsale added API/usability task labels

Member

willkill07 commented Oct 31, 2016

Are there any parts of the API that would break by using one compiler to build RAJA and another compiler to use it (note: I'm assuming binary compatibility with compilers here -- focus is primarily on feature loss)

Member Author

davidbeckingsale commented Oct 31, 2016

In terms of feature loss, I don't think there will be any. The biggest problem would be libRAJA being compiled with nvcc vs. a host compiler.

Member

trws commented Aug 19, 2017

This has been done, closing.

trws closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment