Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types in Tribol #76

Closed
wants to merge 1 commit into from
Closed

Update types in Tribol #76

wants to merge 1 commit into from

Conversation

ebchin
Copy link
Member

@ebchin ebchin commented Apr 12, 2024

This PR introduces new definitions for types in Tribol. The changes are as follows:

  • Remove tribol::integer in favor of int, or other C++ fundamental types as dictated by the specific variable (e.g. unsigned short might make more sense for a variable that represents spatial dimension)
  • Define tribol::IndexT as axom::IndexType for indexing into axom types (e.g. axom::Array). Note the use of tribol::IndexT still needs to be checked in source files. This will be done in future PRs.
  • Rename tribol::real as tribol::RealT and ensure proper usage throughout source files. tribol::RealT is defined as a double; if the user attempts to map it to float by defining TRIBOL_USE_SINGLE_PRECISION, an error will occur since Tribol has not been tested with single precision.
  • Rename tribol::containerArray as tribol::ArrayT and define it as an axom::Array (with template arguments) instead of std::vector
  • Rename tribol::CommType to tribol::CommT to be consistent with other Tribol type names

Note, this PR does not address types in redecomp or in the Fortran/C interface.

@ebchin ebchin requested a review from srwopschall April 12, 2024 18:08
@ebchin ebchin self-assigned this Apr 12, 2024
@ebchin ebchin linked an issue Apr 12, 2024 that may be closed by this pull request
@ebchin
Copy link
Member Author

ebchin commented May 30, 2024

Rolled into #86

@ebchin ebchin closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double vs. Real
1 participant