Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs sparsehash when the external sparsehash package is found #365

Closed
yurivict opened this issue Oct 8, 2020 · 4 comments
Closed

Installs sparsehash when the external sparsehash package is found #365

yurivict opened this issue Oct 8, 2020 · 4 comments
Labels

Comments

@yurivict
Copy link

yurivict commented Oct 8, 2020

Here: https://github.com/LLNL/axom/blob/develop/src/thirdparty/CMakeLists.txt#L184

Despite configure saying that sparsehash is found:

-- Sparsehash configured with '<functional>' header
@rhornung67
Copy link
Member

We should update sparsehash at the same time this is addressed.

@nselliott
Copy link
Contributor

If I understand the request correctly, it would be to make it possible to have headers from an external installation of sparsehash override the headers that we distribute. This would be useful to users that already maintain a sparsehash installation that they use elsewhere in their application. That would mean creating an optional CMake symbol SPARSEHASH_DIR and writing the necessary CMake code to point to headers in $(SPARSEHASH_DIR)/include when a user provides an installation path. Is that the way to go?

@yurivict
Copy link
Author

Sparsehash is available as a package almost on all systems: https://repology.org/project/sparsehash/versions

There should be no need to distribute it, you should just require the external sparsehash package.

@white238
Copy link
Member

white238 commented Dec 7, 2021

This is now guarded by the axom namespace and won't conflict with any users downstream.

@white238 white238 closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants