Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python module cmake creation logic #1205

Closed
cyrush opened this issue Dec 2, 2023 · 1 comment
Closed

update python module cmake creation logic #1205

cyrush opened this issue Dec 2, 2023 · 1 comment
Labels
task
Milestone
0.9.2

Comments

@cyrush
Copy link
Member

cyrush commented Dec 2, 2023

Ascent's distutils-based cmake python module creation logic is a bit more complex than conduit's and it won't survive changes in Python 3.10.

I ported Ascent's cmake logic to use setuptools and pip install, instead of python setup.py as recommend by the python universe.

We should also update this logic in Conduit.
@cyrush cyrush added the task label Dec 2, 2023
@cyrush cyrush mentioned this issue Dec 6, 2023
Merged
@cyrush
Copy link
Member Author

cyrush commented Mar 11, 2024

resolved in #1206 and #1259

@cyrush cyrush closed this as completed Mar 11, 2024
@cyrush cyrush added this to the 0.9.2 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
0.9.2
Development

No branches or pull requests
1 participant
@cyrush