Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datawarp.h missing #31

Closed
c-a-h opened this issue Feb 27, 2017 · 4 comments · Fixed by #36
Closed

datawarp.h missing #31

c-a-h opened this issue Feb 27, 2017 · 4 comments · Fixed by #36
Assignees

Comments

@c-a-h
Copy link
Contributor

c-a-h commented Feb 27, 2017

checking out a clean version of master, the build fails due to not finding datawarp.h
This appears to be the case regardless of configure time options, as I tried enabling and disabling CPPR, and it made no difference.

my configure line was as follows:
./configure --with-file-lock=fcntl --prefix=/home/caholgu1/scr --with-scr-config-file=/home/caholgu1/scr_demo/scr.conf

@c-a-h
Copy link
Contributor Author

c-a-h commented Feb 27, 2017

my first guess is that there is going to need to be a an AM_CONDITIONAL in the x_ac_machine.m4 file so that in Makefile.am the machine specific files can be conditionally included at compile time based upon configuration, similar to what I did with PMIx

@gonsie gonsie self-assigned this Feb 27, 2017
@gonsie
Copy link
Member

gonsie commented Feb 27, 2017

We just had a somewhat messy merge of feature branches onto master. We'll be working out the kinks for the next week or so.

Unfortunately the interface we were using didn't allow for a squash commit of the merge. I believe that commit dae2080 is safe to work from. Make sure you do a git checkout dae208 to get the proper history.

I'll close this issue once master is successfully building again.

@c-a-h
Copy link
Contributor Author

c-a-h commented Feb 27, 2017

Thanks for the update! I will try out the version you referenced.

@c-a-h
Copy link
Contributor Author

c-a-h commented Feb 27, 2017

That version worked. I will have a PR up soon to update SCR to reflect a minor change in the CPPR APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants