Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nnf-dm - Create cmake install for NNFDM client api #508

Closed
mcfadden8 opened this issue Jul 26, 2022 · 3 comments
Closed

nnf-dm - Create cmake install for NNFDM client api #508

mcfadden8 opened this issue Jul 26, 2022 · 3 comments

Comments

@mcfadden8
Copy link
Collaborator

A sample client library has been provided in source code form here: https://github.com/NearNodeFlash/nnf-dm/tree/master/daemons/compute/_client-c. The library is written in go and the Makefile will produce a client.a library file. An install target needs to be made for the client.a library so that it may be included by AXL.

@mcfadden8
Copy link
Collaborator Author

@adammoody - FYI, for testing purposes, my plan is to temporarily include the client.a library and associeated header file in the AXL repo. Please let me know if you would like for me to do this in a different way.

@adammoody
Copy link
Contributor

@mcfadden8 , I don't know what all is in there, but my main concern would be whether we have any NDA info or problems due to incompatible software licenses. If something like that is a concern, we could create a branch and use our internal git repos instead.

@mcfadden8
Copy link
Collaborator Author

Closing this for now. We will assume that a library will be provided at a later date and time and that we will not be building it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants