Skip to content

Commit

Permalink
flake 8 fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
lee218llnl committed Jul 6, 2016
1 parent 4c063c6 commit 4e27d91
Showing 1 changed file with 16 additions and 15 deletions.
31 changes: 16 additions & 15 deletions var/spack/repos/builtin/packages/suite-sparse/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,32 +44,33 @@ class SuiteSparse(Package):
depends_on('metis@5.1.0', when='@4.5.1')
depends_on('metis@5.1.0', when='@4.5.3')
# FIXME:
# in @4.5.1. TBB support in SPQR seems to be broken as TBB-related linkng flags
# does not seem to be used, which leads to linking errors on Linux.
# in @4.5.1. TBB support in SPQR seems to be broken as TBB-related linkng
# flags does not seem to be used, which leads to linking errors on Linux.
# Try re-enabling in future versions.
# depends_on('tbb', when='+tbb')

def install(self, spec, prefix):
# The build system of SuiteSparse is quite old-fashioned
# It's basically a plain Makefile which include an header (SuiteSparse_config/SuiteSparse_config.mk)
# with a lot of convoluted logic in it.
# Any kind of customization will need to go through filtering of that file
# The build system of SuiteSparse is quite old-fashioned.
# It's basically a plain Makefile which include an header
# (SuiteSparse_config/SuiteSparse_config.mk)with a lot of convoluted
# logic in it. Any kind of customization will need to go through
# filtering of that file

make_args = ['INSTALL=%s' % prefix]

# inject Spack compiler wrappers
make_args.extend([
'AUTOCC=no',
'CC=cc',
'CXX=c++',
'F77=f77',
'AUTOCC=no',
'CC=cc',
'CXX=c++',
'F77=f77',
])

# use Spack's metis in CHOLMOD/Partition module,
# otherwise internal Metis will be compiled
make_args.extend([
'MY_METIS_LIB=-L%s -lmetis' % spec['metis'].prefix.lib,
'MY_METIS_INC=%s' % spec['metis'].prefix.include,
'MY_METIS_LIB=-L%s -lmetis' % spec['metis'].prefix.lib,
'MY_METIS_INC=%s' % spec['metis'].prefix.include,
])

# Intel TBB in SuiteSparseQR
Expand All @@ -80,10 +81,10 @@ def install(self, spec, prefix):
])

# BLAS arguments require path to libraries
# FIXME : (blas / lapack always provide libblas and liblapack as aliases)
# FIXME: (blas/lapack always provide libblas and liblapack as aliases)
if '@4.5.1' in spec:
# adding -lstdc++ is clearly an ugly way to do this, but it follows suit
# with the TCOV path of SparseSuite 4.5.1's Suitesparse_config.mk
# adding -lstdc++ is clearly an ugly way to do this, but it follows
# with the TCOV path of SparseSuite 4.5.1's Suitesparse_config.mk
make_args.extend([
'BLAS=-lblas -lstdc++',
'LAPACK=-llapack'
Expand Down

0 comments on commit 4e27d91

Please sign in to comment.