-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spec to build Ferret #1076
Conversation
|
||
depends_on('netcdf') | ||
depends_on('netcdf+mpi', when='+mpi') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have not checked netcdf-fortran
config, but this will not make netcdf-fortran
explicitly depend on mpi
. I think you could achieve the same result for ferret
by declaring it to
depends_on("netcdf~mpi")
depends_on("netcdf-fortran")
which would not require extra variant here. I would say it would be a better way.
(edited to fix typos)
you sure you need to commit a binary and change filemode? |
Okay I rushed and didn't realize that swap file was in my commit, whoops. But your suggestion about the depends_on's makes much more sense, that way the netcdf-fortran specs didn't need to be changed. |
Cool! After fixing flake8 issues (if there are any left), please squash into a single commit and then hopefully someone from maintainers will merge it soon 👍. |
Fixed ferret spec. It builds now Made ferret spec more flake8-y Fixed homepage and info text about Ferret Removed vim swap file Reverted changes to netcdf-fortran spec and added netcdf~mpi dependency to ferret spec to compensate for it Fixed flake8 issues!
Alright, I've rebased and squashed my commits into 448f8c4! |
libz_prefix = spec['zlib'].prefix | ||
ln = which('ln') | ||
ln('-sf', | ||
hdf5_prefix + '/lib', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note you can actually type spec['hdf5'].prefix.lib
. See prefix objects.
@JRWynneIII can fix the strict deps later if he needs to. We can merge this for now. |
This spec will successfully build Ferret from source. Since Ferret seemed to expect a much older version of netCDF I had to have the spec do some special symlinking.