Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify unit tests listed in Contribution Guide #2904

Merged
merged 2 commits into from
Jan 23, 2017

Conversation

adamjstewart
Copy link
Member

If you check out the Contribution Guide, you'll notice that more than a third of the guide is the output of a single command, spack test --collect-only. This PR switches to spack test --list, which only lists the highest level of unit tests and saves space. @alalazo Does this seem okay to you?

@adamjstewart adamjstewart added documentation Improvements or additions to documentation tests General test capability(ies) labels Jan 23, 2017
@tgamblin tgamblin requested a review from alalazo January 23, 2017 17:03
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good change to improve readability. --collect-only is a leftover from when the command was a thin wrapper around pytest.

@tgamblin tgamblin merged commit dae3533 into spack:develop Jan 23, 2017
@adamjstewart adamjstewart deleted the fixes/simple-test branch January 30, 2017 20:31
diaena pushed a commit to diaena/spack that referenced this pull request May 26, 2017
* Simplify unit tests listed in Contribution Guide

* Use long name for option flags
amklinv pushed a commit that referenced this pull request Jul 17, 2017
* Simplify unit tests listed in Contribution Guide

* Use long name for option flags
healther pushed a commit to electronicvisions/spack that referenced this pull request Jul 26, 2017
* Simplify unit tests listed in Contribution Guide

* Use long name for option flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests General test capability(ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants