Fix tab completion of directories and filenames #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgamblin
approved these changes
Feb 20, 2017
|
@adamjstewart: does bash completion use its own columnizer? I noticed the suggested completion output seems to use fixed-width columns, which are not as nice as the variable-width, GNU |
|
Not sure, I'm certainly not doing my own columnizing, so it must be. |
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
amklinv
pushed a commit
that referenced
this pull request
Jul 17, 2017
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compgendoes not work the way I expected.compgen -o filenamesdoesn't list any results. If I usecompgen -o filenames -A fileorcompgen -o default, it will list results, but directories will not have a/appended. The only way to get this working is to usecomplete -o default. This has the unfortunate side-effect of adding directories/filenames as possible values any time there are no other possible results, but I don't see a better way around this.P.S. I just noticed that
spack install []will list all packages, butspack install gcc []will list no results (will now list filenames/directories). I wonder if I can fix this (in another PR).