Make R extendable #757
Merged
Make R extendable #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added R as a build system so that the create template will have the correct configure line. Added a regex for version parsing as the R URLs are a little odd.
| # Set R_LIBS to include the library dir for the | ||
| # extension and any other R extensions it depends on. | ||
| r_libs_path = [] | ||
| for d in extension_spec.traverse(): |
There was a problem hiding this comment.
This will want to look for build and run deps when #378 lands.
…rent systems use different defaults.
|
@mathstuf The latest commit addresses the issue of different libdir settings on different systems by setting libdir at configure time. |
|
@tgamblin I know there are higher priority PRs but I have a question. I would like to start getting some R packages into spack. Should I push those into this PR or wait for this to be merged? Thanks. |
|
ping @tgamblin |
|
@glennpj: this is awesome! Thanks for adding proper R support! |
|
@glennpj: Hopefully this helps you get some more R packages in. Sorry for the delay! |
olupton
pushed a commit
to olupton/spack
that referenced
this pull request
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes R an extendable package. Along with that, R is recognized as a spack build system so that
spack createwill generate template package files for R packages. Three R packages are in this PR that were used to validate the proper functioning of the extended R as well as to provide the first set of R packages for spack.