-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make R extendable #757
Make R extendable #757
Conversation
Added R as a build system so that the create template will have the correct configure line. Added a regex for version parsing as the R URLs are a little odd.
# Set R_LIBS to include the library dir for the | ||
# extension and any other R extensions it depends on. | ||
r_libs_path = [] | ||
for d in extension_spec.traverse(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will want to look for build and run deps when #378 lands.
…rent systems use different defaults.
@mathstuf The latest commit addresses the issue of different libdir settings on different systems by setting libdir at configure time. |
@tgamblin I know there are higher priority PRs but I have a question. I would like to start getting some R packages into spack. Should I push those into this PR or wait for this to be merged? Thanks. |
ping @tgamblin |
@glennpj: this is awesome! Thanks for adding proper R support! |
@glennpj: Hopefully this helps you get some more R packages in. Sorry for the delay! |
This PR makes R an extendable package. Along with that, R is recognized as a spack build system so that
spack create
will generate template package files for R packages. Three R packages are in this PR that were used to validate the proper functioning of the extended R as well as to provide the first set of R packages for spack.