Ensure that trilinos and petsc link to appropriate versions of superlu-dist #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KineticTheory
commented
May 18, 2016
KineticTheory
commented
- Prevent petsc from linking to superlu-dist@5 since this version of superlu-dist is not currently supported by petsc.
- Prevent trilinos versions prior to 12.6.2 from linking to superlu-dist@5.
- Fix formatting to meet pep8 requirements.
- fixes check which versions (if any) of petsc/trilinos supports Superlu_dist 5.0 #901
…lu-dist. - Prevent petsc from linking to superlu-dist@5 since this version of superlu-dist is not currently supported by petsc. - Prevent trilinos versions prior to 12.6.2 from linking to superlu-dist@5. - Fix formatting to meet pep8 requirements.
| # see https://bitbucket.org/petsc/petsc/src/90564b43f6b05485163c147b464b5d6d28cde3ef/config/BuildSystem/config/packages/hypre.py | ||
| # Hypre does not support complex numbers. Also PETSc prefer to build it | ||
| # without internal superlu, likely due to conflict in headers see | ||
| # https://bitbucket.org/petsc/petsc/src\ |
There was a problem hiding this comment.
maybe add # NOQA: ignore=E501 so that the link is not broken and it is easy to copy-paste it to a browser?
There was a problem hiding this comment.
@davydden I didn't like breaking those URLs, but I was just trying to get through the current pep8 filters. I'll update these files based on your suggestion and resubmit the PR.
There was a problem hiding this comment.
resubmit the PR.
no need ot resubmit the PR, just push the changes here, to the existing PR.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.