Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUNDIALS_LOGGING_ENABLE_MPI defaults to the value of ENABLE_MPI which can cause difficulties for some users #177

Closed
balos1 opened this issue Jul 18, 2022 · 1 comment
Assignees
Labels

Comments

@balos1
Copy link
Member

balos1 commented Jul 18, 2022

See https://groups.google.com/g/sundials-users/c/ed-8wD81Bw0

@balos1 balos1 self-assigned this Jul 18, 2022
@balos1
Copy link
Member Author

balos1 commented Jul 18, 2022

Perhaps we should just change https://github.com/LLNL/sundials/blob/main/cmake/SundialsBuildOptionsPre.cmake#L88 to

sundials_option(SUNDIALS_LOGGING_ENABLE_MPI BOOL "${DOCSTR}" 
"OFF" DEPENDS_ON ENABLE_MPI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant