Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install overwrites googletest #66

Closed
NAThompson opened this issue Aug 5, 2019 · 2 comments
Closed

make install overwrites googletest #66

NAThompson opened this issue Aug 5, 2019 · 2 comments
Labels

Comments

@NAThompson
Copy link

When running make install, the gtest headers are installed to /usr/local/include, overwriting any version of gtest that might already be installed.

@salasoom
Copy link
Member

salasoom commented Aug 6, 2019

I have verifed this happens when Makefiles are generated through CMake, on the develop branch.

In the meantime if you need to install headers, I would suggest checking out the master branch (pointing to the latest release of ZFP), or downloading an official release here.

We changed the default branch from master to develop because incoming pull requests were based on master, and we suspected users were cloning the repo and immediately working with the default branch. For our master branch (containing official releases), we omit the testing frameworks, so gtest headers should not be overwritten from there.

We will update this thread when fixed.

@lindstro lindstro added the bug label Nov 7, 2019
@GarrettDMorrison
Copy link
Member

Closing this as the issue should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants