Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Javadoc #365

Closed
Palmr opened this issue Apr 12, 2021 · 0 comments
Closed

Missing Javadoc #365

Palmr opened this issue Apr 12, 2021 · 0 comments
Assignees
Projects
Milestone

Comments

@Palmr
Copy link
Member

Palmr commented Apr 12, 2021

I was looking at tightening the Checkstyle rules but had to comment out rules checking for Javadoc on publicly scoped types, methods and variables.

The following is a list of currently missing Javadoc which we should get cleaned up for a 4.0 release:

[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/BatchStartAware.java:8:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/DataProvider.java:18: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/DataProvider.java:20:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:15: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:17:9: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:20: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:22:9: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:22:21: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:22:29: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:25:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:37:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:77:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventPoller.java:101:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventProcessor.java:41:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventSequencer.java:3: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/EventSink.java:3: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/InsufficientCapacityException.java:28:5: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/LiteTimeoutBlockingWaitStrategy.java:18:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/PhasedBackoffWaitStrategy.java:33:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/RingBuffer.java:118:5: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/Sequenced.java:3: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/Sequencer.java:93:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/SleepingWaitStrategy.java:40:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/SleepingWaitStrategy.java:45:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/SleepingWaitStrategy.java:50:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/TimeoutBlockingWaitStrategy.java:20:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/TimeoutException.java:3: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/TimeoutException.java:6:5: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/TimeoutHandler.java:3: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/TimeoutHandler.java:5:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/dsl/ExceptionHandlerWrapper.java:6: Missing a Javadoc comment. [JavadocType]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/dsl/ExceptionHandlerWrapper.java:10:5: Missing a Javadoc comment. [JavadocMethod]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/util/DaemonThreadFactory.java:25:5: Missing a Javadoc comment. [JavadocVariable]
[ant:checkstyle] [ERROR] /home/nick/git-projects/disruptor/src/main/java/com/lmax/disruptor/util/Util.java:145:5: Missing a Javadoc comment. [JavadocMethod]
@Palmr Palmr added this to the 4.0 milestone Apr 12, 2021
@Palmr Palmr added this to To do in 4.0 Apr 12, 2021
@Palmr Palmr closed this as completed in bf60440 Sep 17, 2021
@Palmr Palmr moved this from To do to Done in 4.0 Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0
Done
Development

No branches or pull requests

2 participants