Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a tag #2

Closed
amstan opened this issue Oct 31, 2022 · 3 comments
Closed

Please create a tag #2

amstan opened this issue Oct 31, 2022 · 3 comments

Comments

@amstan
Copy link

amstan commented Oct 31, 2022

So that git describe --long --tags works.

I see that you're also an Arch fan, but if i try to edit the PKGBUILD with your repo it'll fail the building due to the pkgver() code, that could easily be fixed by you adding a tag in this repo. At least make it match the upstream's tag so version numbers are portable, or perhaps make a new namespace.

@FabioLolix
Copy link

+1 for pushing the tag

with your repo it'll fail the building due to the check() code

in the pkgbuild there isn't a check() function, it is the pkgver() function that fails if there aren't git tag

which you can change to from "git describe ..." to

printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

Incrementing epoch to 2 is also necessary if you update your pkgbuild with AUR helpers

https://wiki.archlinux.org/title/VCS_package_guidelines#Git

@LMBernardo
Copy link
Owner

I've added a tag with a minor version bump. If this works now, let me know and I will close this issue.

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants