Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : quest completed for shopguiplus task without to have to sell any items #496

Closed
3 tasks done
HamtaBot opened this issue Feb 27, 2023 · 6 comments · Fixed by #498
Closed
3 tasks done

BUG : quest completed for shopguiplus task without to have to sell any items #496

HamtaBot opened this issue Feb 27, 2023 · 6 comments · Fixed by #498
Labels
bug status: accepted Feature request accepted / bug report confirmed

Comments

@HamtaBot
Copy link

Description of Bug

if you create a quest with shopguiplus to sell for exemple 500 items
then start it, you can complete it by just opening the shop going to the asked item and click on ''sell more" without having the items in your inventory , it will say that you dont have items to sell but will actually complete the quests
So this thing destroyed my economie when players noticed it ..

Steps to Reproduce

i said exactly what you need to to on the top

Environment

  • Minecraft version: 1.17.1
  • Server software: pufferfish
  • Quests version: latest on spigot

Agreements

  • I am running the latest version of Quests
  • I am certain this issue is unique and a similar issue is not currently open
  • I am using a version of Minecraft which is supported by Quests

Other

No response

@HamtaBot HamtaBot added bug status: needs investigating Bug report / feature request needs investigating and triage labels Feb 27, 2023
@Krakenied
Copy link
Contributor

Is your Quests plugin up to date?

@HamtaBot
Copy link
Author

Is your Quests plugin up to date?

i am using the latest version on spigot : Quests-3.13.3-5a28efa.jar

@HamtaBot
Copy link
Author

HamtaBot commented Mar 7, 2023

@Krakenied

@Krakenied
Copy link
Contributor

Krakenied commented Mar 7, 2023

Ok it seems that the task type was always broken

@HamtaBot
Copy link
Author

HamtaBot commented Mar 8, 2023

is the pull requets applied ? i can't seems to find it on the actions tab @Krakenied

@HamtaBot
Copy link
Author

HamtaBot commented Mar 8, 2023

oh its building thanks

@LMBishop LMBishop added status: accepted Feature request accepted / bug report confirmed and removed status: needs investigating Bug report / feature request needs investigating and triage labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: accepted Feature request accepted / bug report confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants