Fix export for some locales #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change those ints to const... (just for good coding practices) |
|
Ok, done. |
|
Wow, I would never have imagined this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some translators might change a given frequency from Hz to KHz to make the phrase shorter or fit a specific style. But as we were reading out the string and passing the numbers to a function, this caused problems resulting in Export causing to frees LMMS. This addresses issue #1496
Now we simply store the corresponding bit-/samplerates for the Boxes in an array and get the values from it instead of trying to get the number from the translated string.