Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu for notes in Piano Roll #1569

Open
Sti2nd opened this issue Jan 7, 2015 · 16 comments
Open

Context menu for notes in Piano Roll #1569

Sti2nd opened this issue Jan 7, 2015 · 16 comments

Comments

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 7, 2015

Placeholder for ideas, feel free to comment and edit.

Context menu content

  • Mute
  • Detune
  • Razor selected notes / Glue selected notes Piano Roll Razor/Glue Tool #746
  • Put to the background/place behind (when notes overlapping)
  • Delete all notes behind (all overlapping notes on the same note label)
  • Show information?
  • Change color
  • Cut/Copy/Paste

Information?

  • Note label (C4, G#4/Ab4)
  • Note duration/lenght
  • Note velocity/volume
  • Note panning value
@tresf tresf added this to the 1.3.0 milestone Jan 7, 2015
@ShurikMur
Copy link

Agreed.
BTW can't find a feature to change color of notes, it also can be done in a context menu.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

Today we use the right mouse button to delete notes, what should we do to open the context menu?

@musikBear
Copy link

would it be an option to let the context-menu be opend, not on the selected notes, but on the hot-spot in the volume-pan section eg
pastenot
instead of or as an extending of current menu?

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Jan 28, 2015

Today we use the right mouse button to delete notes, what should we do to open the context menu?

Already addressed #1488

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@Sti2nd What was addressed? Do you have a suggestion?

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Jan 28, 2015

Do you have a suggestion?

Yes, even some shortcuts that don't yet exist (but are issues) are in the table. Delete in Piano Roll will probably Shift + right click and middle click.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@tresf @Sti2nd Can you confirm that this is what everyone has agreed? I can tell for myself: I hate having to use the middle or a composed right click to delete stuff, but if this change is consensus then it's fine.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

I have to agree with @Sti2nd, we can't have our cake and eat it too. If we want a context-menu, we have to free up the shortcut that is stealing it. Middle-click is what we use for song editor. @Sti2nd is helping us manage these conflicts so I will defer to him in this case as far as our long term goal -- he's done the most research on it.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

Fine by me :-)

@tresf
Copy link
Member

tresf commented Jan 28, 2015

Shift + right click and middle click

Isn't Shift + Left click what we use for middle?

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Jan 28, 2015

Isn't Shift + Left click what we use for middle?

Shift + right click :) You made me afraid there! Thanks for being vigilant, it is valuable feedback.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

Shift + right click :) You made me afraid there! Thanks for being vigilant, it is valuable feedback.

Ah yes. :)

@ShurikMur
Copy link

An option to bind keys by user can solve all those problems :)
And one more question: there are so many things to improve in a piano roll, maybe the discussion needs a some separate pool?
The music scales function is already sown in an upper bar, but still didn't work.

@tresf
Copy link
Member

tresf commented Jan 29, 2015

The music scales function is already sown in an upper bar, but still didn't work.

I'm not sure what this means and I think you are right, it probably deserves a different place for discussion.

  • When you say "sown" do you mean shown?
  • When you say "upper bar" do you mean the toolbar?

Our wiki has some very basic instructions for dealing with scales and chords, which is hidden a bit in the context menu when you right-click the keys (which I assume you already know since you brought it up in this thread). If there is something broken please do file a bug.

http://lmms.io/wiki/index.php?title=Piano_Roll_Editor

@ShurikMur
Copy link

Yes, sorry for typos.

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Jan 29, 2015

maybe the discussion needs a some separate pool?

No, it needs several. Piano Roll as topic is too general. You can perhaps manage to group them somewhat, but you can also leave that to us. It is easier to keep track of what needs to be done and have been done if we can close out issues, and one can't close out issues if they contain several issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants