Recover file dialog buttons mismatch

[Umcaruje]

LMMS master branch, built yesterday (d30a7df).

OS: Elementary OS Freya x64, Ubuntu based distro.

When I crash LMMS and an recovery is attempted, the dialog looks like this:

Instead of this (Picture from #2176)

So the 'discard' button became 'Close without saving' and also the actual order of the buttons changed.

On the other hand, I think the order of the buttons should be the same as the order of the columns (recover, ignore, discard, exit rather than recover, discard, ignore, exit).

I also think that 'Quit' should be renamed to 'Exit' in the text.

I'm sorry for pointing out these issues now, but I never got around testing #2176

Tagging @zonkmachine since he's the author of the mentioned PR.

[zonkmachine]

• 'Close without saving' and order of buttons
  Are you on Qt5?
• Quit and Exit should be one and the same
  I change to 'Exit' in the text.
• Ignore button icon gone.

[Umcaruje]

Are you on Qt5?

I didn't build with qt5, though I do have it installed on my system.

[zonkmachine]

And the icon on the Ignore button is gone. 😢

[Umcaruje]

If its of any help, when I run qmake -v I get

QMake version 3.0
Using Qt version 5.2.1 in /usr/lib/x86_64-linux-gnu

But I do not run my builds with -DWANT_QT5=ON. That should mean that cmake should use qt4, right?

[zonkmachine]

Mine reads:

QMake version 2.01a
Using Qt version 4.8.6 in /usr/lib/x86_64-linux-gnu

But I do not run my builds with -DWANT_QT5=ON. That should mean that cmake should use qt4, right?

One would assume so. I haven't tried Qt5.
The order of the buttons are defined by button roles, apparently, and I thought I had this one figured out. I'll dive into it once more. The "Close without Saving" button text is a mystery.

[zonkmachine]

@Umcaruje Trying some fixes now. What theme are you using? Are those button icons from a system or an LMMS theme?

[Umcaruje]

Actually, they seem to be a mix of both. The recover and close without saving buttons use icons from my system theme (numix-icon-circle), while the exit button is from the LMMS theme. Even when I revert to the default theme, there is no icon next to the Ignore button.

[zonkmachine]

Even when I revert to the default theme, there is no icon next to the Ignore button.

Do you run it directly from the build directory with ./lmmsor do you make install first? I have to install for the Ignore icon to show up.

[Umcaruje]

Doing make install doesn't make the icon show up.

<offtopic> I'm on IRC right now, and for the sake of not spamming this thread back and forth, you could perhaps hop on to #lmms over on freenode.net, that might make it easier.</offtopic>

[tresf]

Is there a way for us to update the html table/GUI with the text from the buttons?

[Umcaruje]

@zonkmachine this is how it looks over on qt5:

No icons, and button height varies, but the text seems to be there.

[mikobuntu]

This is how the recovery window looks in current Master branch using QT5 also ( unsure if QT related )

[zonkmachine]

unsure if QT related

I think it's rather "zonkmachine related" I'm afraid...

[zonkmachine]

The message "Close without Saving" is called in qt with the following line:

else if (layoutPolicy == QDialogButtonBox::GnomeLayout)
            buttonText = QT_TRANSLATE_NOOP("QDialogButtonBox", "Close without Saving");

[zonkmachine]

The differences seem to stem from the desktops using different orders for the button roles as explicitly defined in qdialogbuttonbox.cpp

    // Qt::Horizontal
    {
        // WinLayout
        { ResetRole, Stretch, YesRole, AcceptRole, AlternateRole, DestructiveRole, NoRole, ActionRole, RejectRole, ApplyRole,
           HelpRole, EOL, EOL, EOL },

        // MacLayout
        { HelpRole, ResetRole, ApplyRole, ActionRole, Stretch, DestructiveRole | Reverse,
          AlternateRole | Reverse, RejectRole | Reverse, AcceptRole | Reverse, NoRole | Reverse, YesRole | Reverse, EOL, EOL },

        // KdeLayout
        { HelpRole, ResetRole, Stretch, YesRole, NoRole, ActionRole, AcceptRole, AlternateRole,
          ApplyRole, DestructiveRole, RejectRole, EOL },

        // GnomeLayout
        { HelpRole, ResetRole, Stretch, ActionRole, ApplyRole | Reverse, DestructiveRole | Reverse,
          AlternateRole | Reverse, RejectRole | Reverse, AcceptRole | Reverse, NoRole | Reverse, YesRole | Reverse, EOL },

        // Mac modeless
        { ResetRole, ApplyRole, ActionRole, Stretch, HelpRole, EOL, EOL, EOL, EOL, EOL, EOL, EOL, EOL, EOL }
    },

[follower]

FWIW, in case this is useful (and, you know, I actually took a screenshot, so might as well use it :) ) with 1.1.91 from #2890 on Mac OS X 10.8.x the dialog looked like this:

I haven't tested with master to test the fix in #2908.

[zonkmachine]

I haven't tested with master to test the fix in #2908.

Which is the information we need. Test the next RC build when it's out (not done cooking yet).