key-combo to change note-length in piano-roll

[musikBear]

Add key-combo for length-change of selected notes in piano-roll.
Change of length should be the value selected in Q drop-down.

[tresf]

A workaround for (what I think) you are describing is to select the tiny note along with a larger one and resize them together.

[musikBear]

no, it would not, the mouse-movement would be the same
Only work-around is to magnify, but then over-view is lost -Its a logic addition to the piano-roll' note handling tresf.

[tresf]

Ok, so this request is a keyboard shortcut to grow and shrink the size of an already selected note pattern? Can you explain the expected behavior? A drawing will help. e.g. Should the note be appended the exact quantiziation size or should the note's end snap to the nearest quantization or should the note size increase to equal the exact quantization? The more specific you are in the request, the easier this will be for a programmer to code.

[BaraMGB]

Is this a kind of note length quantisation?

[tresf]

Is this a kind of note length quantisation?

Part that and part "my notes are too fricken small, don't make me use my mouse to fix 'em" quick shortcut.

[musikBear]

Ok, so this request is a keyboard shortcut to grow and shrink the size of an already selected note pattern?

Yes

Should the note be appended the exact quantiziation size or should the note's end snap to the nearest quantization or should the note size increase to equal the exact quantization?
Change of length should be the value selected in Q drop-down

So in your words:

the note be appended the exact quantiziation size

yes, the note should be appended the exact chosen quantiziation size

It is all about to avoid using very small movements of the mouse, because they are really difficult to do.
With key-combo there is no problem extending a marked note with f.i. 1/64.

Can you explain the expected behavior?

The user mark the note(s), holds the comboCtrl, lets say alt-gr and press right-arrow once. That would then append the value chosen in the Q-dropdown to selected note(s). That is very difficult to do with dragging of the mouse, especially after several times doing it. It is ergonomic-mechanics.

But try this
Make a 1/16 note and then attempt to either extend or shrink that note with only exactly 1/64
Do it 10 times
Easy?

[musikBear]

I would like to do this, if its alright?
If so please assign me (I cant do that my self -right? Assigning to an issue -why not?)

I practically already have made it as 'humanizer' just need to remove randomness and find out how to make a key-combo

[Spekular]

just need to remove randomness and find out how to make a key-combo

I would assume you should look inside keyPressEvent in PianoRoll.cpp. It may be useful to know that Shift+Arrow moves notes left/right by one step of the current Q.

[musikBear]

This is now 'finished'
Not in PR and not reviewed
Implemented as keypress on

• '+' : elongate selected notes 1/192
• '-' : shortens selected notes 1/192

I have 5 ' Hub-#mark' features implemented by now. When is it common to make a PR-request?
Should i do that now, or later?

[zonkmachine]

Hub-#mark'

?

When is it common to make a PR-request?

Depends on if you need help with it. It's hard to give feedback without looking at the code. Just open a PR for the one you think is most ready and see what unfolds.

[musikBear]

open a PR for the one you think is most ready and see what unfolds

@zonkmachine oki will do

nb Hub-#mark -i meant issues / enhancements tickets on gitHub