Instrument height wrong with four or more effect units

[zonkmachine]

When you add four or more effect units i an instrument it's height gets stretched.
This is on master since a966d25

Method to replicate:

• Add four effects to an instrument
• Save and reload.

[zonkmachine]

This is on master since a966d25

@JohannesLorenz

[JohannesLorenz]

I just used 3osc, switched to FX tab and added 5 effects. No resize.

Can you please describe the exact steps required to repoduce? Maybe it's even fixed 1 month later, now that @PhysSong fixed the instrument window caching.

[PhysSong]

You can try saving and reloading after adding a lot of effects.

[zonkmachine]

you are right, I can't replicate this. Not now and not on master at the time of this PR. I think I may have been in the middle of a bisect and forgot about it. At least that would explain it. Closing.

[PhysSong]

I still can. You should add 4 or more effects and save to a project file and reload this. Otherwise, you won't get this bug with the latest master.

[michaelgregorius]

This issue can still be reproduced. One quick way to do so with a stock master was described in #6268:

1. Drag the preset "Kicker/SnareMarch.xpf" into the Song Editor.
2. Open the instrument.