Choosing "send to active instrument-track" does not update name of track

[Gissyup4]

Bug Summary

When using the option send to active instrument-track with a sample from "My Samples", the name of the track is not updated in the timeline editor.

Steps to reproduce

Chose sample and added to timeline editor. Next left clicked the added track in timeline editor and then right clicked a random sample from My Samples side tab and chose "send to active instrument-track".

Expected behavior

The name of track will update to reflect the chosen sample has been sent to chosen track

Actual behavior

The sample is sent to the track as expected, but the name of the chosen sample is not sent to the track

Screenshot

Affected LMMS versions

LMMS 1.3.0-alpha.1.34+g3c36365af

[Spekular]

I thought it'd be possible to handle this in the new replaceInstrument method from #5957, but something fishy is going on so I haven't figured it out yet. Everything except samples seems to already update as one would expect, including:

• The first time a sample replaces another instrument
• Replacing a non-sample preset with another preset of the same instrument

So something specifically about replacing an AFP track with an AFP preset is different. From my testing, either replaceInstrument doesn't get called, or instrumentName doesn't return "AudioFileProcessor", so the former seems likely.