Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a gap between the Note Velocity/Pan toggling and the Volume/Pan bars in Volume/Pan editor of Piano Roll #6413

Open
anishbl opened this issue May 24, 2022 · 3 comments

Comments

@anishbl
Copy link

anishbl commented May 24, 2022

Enhancement Summary

Adding a note at the the very beginning causes the note's Volume/Pan bar to be half hidden by the Volume/Pan toggling, and frequently causes switching from Volume to Pan or vice versa when one tries to edit said quality of the very first note/ the leftmost note of the visible section of the piano roll

image

image

Pan-vol.mp4

Possible solutions are:

  1. Providing a gap between the bars and the switch, which would involve separating all of the notes from the keyboard on the left by a small margin
  2. Reducing the size of the switch from the entire rectangle to the left on the notes to a small area.

Justification

This isn't a major problem, and can be easily worked around by being careful/moving note to the right to change volume/scrolling to an appropriate position (this one doesn't work if it's the first note, in the very beginning of the first bar), but it is quite an avoidable issue, and modifying it would provide a more seamless experience to users.
The improvement in experience and preventing such minor annoyances, to people new to LMMS and unused to the quirk at any rate, I believe would be worth the change.

Mockup

image

Possible option? But there are any number of ways to solve this.

@Spekular
Copy link
Member

I would personally propose that an actual control (combo box or similar) is introduced, and/or a right click menu. If we stop relying on the entire label region as a trigger to switch mode, it might be possible to forward LMB events to the slider region. Having a list available would also be good in order to expose additional note properties in the future, should they be added.

@Monospace-V
Copy link
Contributor

Monospace-V commented May 24, 2022

Having a list available would also be good in order to expose additional note properties in the future, should they be added.

I think this is an interesting prospect. A lot of physical instruments have "brighter" filter envelopes as volume increases. Would be wonderful to have some possible way of modifying this, so we can actually "humanize" velocity even on synthesized instruments or samples/SF2s without volume layers.
This would make it possible to perhaps add something like this. Apart from volume and panning, perhaps a mild band boost or something like that, on a specific frequency, etc.
It could be a drop-down, like that of quantization value and chord and scale.

@allejok96
Copy link
Contributor

it might be possible to forward LMB events to the slider region

Yes, given that the entire editor is a single widget 🤦 Should be quite easy. Just add another if statement and run before you disturb the ancient magic numbers and you are forced to eat the spaghetti that holds everything together. If you don't believe me, ask Veratil. He has seen some pasta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants