Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Music and Virtual Libraries #437

Closed
CDrummond opened this issue Oct 13, 2020 · 4 comments
Closed

New Music and Virtual Libraries #437

CDrummond opened this issue Oct 13, 2020 · 4 comments
Labels
Milestone

Comments

@CDrummond
Copy link
Contributor

CDrummond commented Oct 13, 2020

When Material is listing "New Music" it uses the following JSONRPC command:

["albums",0,25000,"sort:new","tags:ajlsyKSE","menu:1","library_id:LIBRARYID"]

It appears as if LMS filters the returned items using library_id after obtaining the 100 newest albums. Therefore, if all albums in library_id are older than the 100 newest, nothing is returned.

With the default UI, setting a library sets it per-player. In this instance the library_id is used correctly. i.e. LMS obtains the album in library_id, then gets the 100 newest.

Discussed on forum:
https://forums.slimdevices.com/showthread.php?111797-separate-libraries&p=969087&viewfull=1#post969087
https://forums.slimdevices.com/showthread.php?109624-Announce-Material-Skin&p=991166&viewfull=1#post991166

@mherger mherger added the bug label Oct 13, 2020
@mherger
Copy link
Contributor

mherger commented Oct 13, 2020

The albums query code indeed does cache using the client's library_id rather than the one passed as a parameter.

Need to review whether similar corner-cases do exist in other queries, too.

@mherger
Copy link
Contributor

mherger commented Nov 22, 2020

@CDrummond did I ever address this issue?... I wanted to look into other cases. But did I fix this one?

@CDrummond
Copy link
Contributor Author

@mherger Not as far as I can tell. Just tried the following, using Material Skin (as it does not set library on player):

  1. Checked current 'New Music'
  2. Performed advanced search to select an album no currently in 'New Music'
  3. Created a virtual library from results
  4. Changed to virtual library
  5. Re-open 'New Music'
  6. List is empty

@michaelherger
Copy link
Member

I should leave notes about findings here. Because I must have looked into this before, decided not to do it right away, but didn't write down why. Now I have to start over. Stupid me.

@mherger mherger added this to the 8.0.1 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants