HTTP range request is LAST byte not SIZE !!!!! #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That explain missings last seconds on mp4 I'm a (very angry) muppet
Comment on lines
734
to
+735
| if ($first) { | ||
| $request .= $CRLF . 'Range: bytes=' . ($first || 0) . '-' . ($song->track->audio_size || ''); | ||
| $request .= $CRLF . 'Range: bytes=' . ($first || 0) . '-'; |
There was a problem hiding this comment.
Is it ok to only define the first byte, but not end?
And the ($first || 0) is a bit redundant, as there's the if ($first) check first.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I can change that (the first) as well. That the result of a different code structure at the beginning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That explain missings last seconds on mp4.
I'm really sorry, I could have seen that any day since June, but it had to be today, one day after the release of 8.1
I'm a (very angry) muppet