scanURL waits for bitrate when startTime is needed #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning a mp3 stream, we have to wait for bitrate which might be found in body, not in header. So we wan't do scan in background, we have to wait
|
What problem does this change solve? Is there any way I can test this change in behavior? |
|
yes, use a mp3 podcast that is http, not https and have no redirect. Play it for >15s and then play if "from last position". Prior to this PR, it would restart from beginning because the bitrate would not be acquired before getNextTrack is called, i.e. before the bitrate is needed to calculate offset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning a mp3 stream, we have to wait for bitrate which might be found in body, not in header. So we wan't do scan in background, we have to wait