Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled I18N::LangTags::Detect fails to load #715

Closed
thoukydides opened this issue Dec 20, 2021 · 3 comments
Closed

Bundled I18N::LangTags::Detect fails to load #715

thoukydides opened this issue Dec 20, 2021 · 3 comments

Comments

@thoukydides
Copy link

With Perl v5.30.0 on Ubuntu 20.04.3 LTS, a plugin that attempts to use I18N::LangTags::Detect; results in the error:

Slim::bootstrap::tryModuleLoad (286) Warning: Module [Plugins::XXX::Plugin] failed to load:
Can't use 'defined(%hash)' (Maybe you should just omit the defined()?) at /usr/share/squeezeboxserver/CPAN/I18N/LangTags/Detect.pm line 140.

This was fixed by Perl/perl5@08f2910 in verion 1.04 of I18N::LangTags::Detect, but Logitech Media Server is still shipping with version 1.03. (The current version is 1.08.)

@michaelherger
Copy link
Member

Thanks for the hint! This module has been part of Perl (core) since v5.12. Time to get rid of our outdated copy.

Which plugin would be using it? Can you confirm it's working still (new LMS 8.3 builds will be out soon)?

@thoukydides
Copy link
Author

I have just confirmed that it is fixed in the logitechmediaserver_8.3.0~1640066892_all.deb nightly build. Nothing else is obviously broken. Thank you.

I noticed the problem with an unpublished plugin that I developed to integrate with some of my home automation systems. It uses the Number::Phone package to format and lookup Calling Line Identification Presentation (CLIP) numbers, and it is the Number::Phone::StubCountry package within that which tripped over the issue.

@mherger
Copy link
Contributor

mherger commented Dec 21, 2021

Thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants