Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very small fix: bogus perl version queries #799

Closed
stsichler opened this issue Jul 14, 2022 · 4 comments
Closed

Very small fix: bogus perl version queries #799

stsichler opened this issue Jul 14, 2022 · 4 comments

Comments

@stsichler
Copy link
Contributor

Hi,
I just stumbled across an old commit from me in my fork of the slimserver which I never created a pull request from.
Please see my commit 516a500
(and explanation: https://www.tutorialspoint.com/perl/perl_special_variables.htm)

It's so long ago that I was actively working on that repo and it's such a small fix that I don't want to do the full process of update from upstream, checkout, create a feature branch for that and make a pull request....

Can anybody currently actively working here just (test and) commit this?
Thanks!

@michaelherger
Copy link
Member

Thanks for the hint. Both these issues have been fixed upstream already. For IO::String it even seems to be the only change since the already old version we're using... (see https://metacpan.org/dist/IO-String/changes, latest entry). We might just update those modules instead of patching them.

@stsichler
Copy link
Contributor Author

...We might just update those modules instead of patching them.

👍

@stsichler
Copy link
Contributor Author

Btw. it's very cool that you all actively still maintain the Squeezebox Server!
I'm happily still using all my Squeezeboxes and would not know how to replace them when they stopped working eventually...

THANK YOU!

It's a shame that they are no longer produced.

@mherger mherger closed this as completed in 4587ea5 Dec 1, 2022
@mherger
Copy link
Contributor

mherger commented Dec 1, 2022

I decided not to deal with PAR, as I'd rather remove that module. It's really legacy for some really, really old plugins which haven't been maintained in a decade or more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants