Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library views and Random mix preference interaction #531

Closed
epoch1970 opened this issue Feb 6, 2021 · 2 comments
Closed

Library views and Random mix preference interaction #531

epoch1970 opened this issue Feb 6, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@epoch1970
Copy link

Hi Michael ;)
I think there is an issue when setting a player to use a library view, and at the same time setting random mix to pick songs from another library view.
In this case 'playlist add randomplay://tracks' returns an empty playlist.

I had an install running fine for a long time when a single library view was defined. Then when a second one was added, empty random playlists started to crop up.
Bug or not? Anything can be done?

Cheers.
https://forums.slimdevices.com/showthread.php?113861-Player-library-views-and-random-mix-preferences-interaction

@mherger mherger added the bug label Feb 7, 2021
@mherger mherger self-assigned this Feb 7, 2021
@mherger mherger added this to the 8.1.2 milestone Feb 7, 2021
@mherger
Copy link
Contributor

mherger commented Feb 7, 2021

Ok, I can confirm there's some conflict: the random play plugin would extract the correct track ID, but when trying to play, the playlist addtracks command would apply the client's library, filtering out that track ID. I'm not sure yet whether this should be considered a bug in the addtracks routine, which, given a track ID, should just play that track. Or whether RandomPlay should always define what library to use...

@mherger mherger closed this as completed in d317f80 Feb 7, 2021
@epoch1970
Copy link
Author

epoch1970 commented May 4, 2021

Me again...
I think I have found another ramification of the initial problem, where random selection can be locked-down to a specific genre that doesn't exist in the library view of a player. That player will cease receiving new items for its playlist.
I have not verified the problem exists in the latest version of LMS.
I am able to work around the issue, poorly, by sending playerid randomplaygenreselectall 0 right before sending playerid playlist add randomplay://tracks. But that doesn't stick if someone uses the GUI and selects genres while the player is active.

EDIT. I looked at Mixer.pm and found I could easily unset $queryGenres in case getLibraryIdForClient() has given a value to $queryLibrary. That's enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants