Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you create an album browse mode AND filter by contributor role, sorting by artist doesn't work any more #536

Closed
michaelherger opened this issue Feb 19, 2021 · 1 comment
Closed

If you create an album browse mode AND filter by contributor role, sorting by artist doesn't work any more #536

michaelherger opened this issue Feb 19, 2021 · 1 comment
Assignees
@mherger
Labels
bug
Milestone
8.1.2

Comments

@michaelherger
Copy link
Member

From http://forums.slimdevices.com/showthread.php?t=113980:

I was trying to find a way to browe mi hi res albums and found one
Creating a entry HI Res in custom browse, selecting COMPOSER having
previously tagged all my HI Rest Albums with FLAC24 tag as composer.
The menu appears and i see all mųy hi res albums
But the pb is that they do appear in orders that never start with artist
despite i choose it

ext browse mode
@mherger mherger self-assigned this Feb 19, 2021
@mherger mherger added the bug label Feb 19, 2021
@mherger mherger added this to the 8.1.2 milestone Feb 19, 2021
@mherger
Copy link
Contributor

mherger commented Feb 19, 2021 •
edited

The problem is that the relationship between album and contributor is done based on the role the contributor has (composer in your case). Therefore the sorting happens on the composer, rather than the album artist shown. But that role currently isn't shown. Therefore the confusing result.

mherger added a commit that referenced this issue Feb 20, 2021
@mherger
Fix #536 An album list filtered by role sometimes doesn't how the rol…
c48e318 
…e contributor's name

In LMS web UI you can have an album filtered by role `COMPOSER`. Sorting the list by that role could lead to confusing results, as the `COMPOSER` wouldn't be shown as an artist for the albums, but only the album artist.

Make sure we put the role, by which we filter, at the top or the artists list to be shown.
@mherger mherger closed this as completed Feb 20, 2021
mherger added a commit that referenced this issue Feb 24, 2021
@mherger
#536 Only put specific contributors first if a specific role is expli…
d076ebd 
…citly requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherger mherger

Labels
bug
Projects
None yet
Milestone
8.1.2
Development

No branches or pull requests
2 participants
@mherger @michaelherger