Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match full string when checking against disabled SN apps #545

Closed
PaulWebster opened this issue Feb 28, 2021 · 0 comments
Closed

Match full string when checking against disabled SN apps #545

PaulWebster opened this issue Feb 28, 2021 · 0 comments
Assignees
@mherger
Labels
bug
Milestone
8.1.2

Comments

@PaulWebster
Copy link

PaulWebster commented Feb 28, 2021 •
edited

In current code, substring match results in plugins with similar names being removed from device home menu
See https://forums.slimdevices.com/showthread.php?114038-Plugin-not-appearing-in-non-Jive-SB-player

Solution:
Slim/Buttons/Home.pm

change line 675
next MENU if $menuOption =~ /$plugin/i;
to
next MENU if $menuOption =~ /^$plugin$/i;

problem introduced in 2009 (7.3.3).
84ed64c
@mherger mherger self-assigned this Mar 1, 2021
@mherger mherger added the bug label Mar 1, 2021
@mherger mherger added this to the 8.1.2 milestone Mar 1, 2021
@mherger mherger closed this as completed in 1a186e7 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherger mherger

Labels
bug
Projects
None yet
Milestone
8.1.2
Development

No branches or pull requests
2 participants
@PaulWebster @mherger