Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No result return while using Chinese Keyword in Fulltext Search #852

Closed
silenker opened this issue Dec 25, 2022 · 12 comments
Closed

No result return while using Chinese Keyword in Fulltext Search #852

silenker opened this issue Dec 25, 2022 · 12 comments
Assignees
Labels

Comments

@silenker
Copy link

Hello,
I updated my Daphile to the latest 22.12-x86_64 version which LMS 8.3 included.There's a problem with quick search.You get nothing when using Chinese Keyword in quick search,but correct results returned when using the same Keyword in advance search.Try to rebuild database but no help.

@michaelherger
Copy link
Member

Stupid question: would it find anything else? Is a player connected?

@silenker
Copy link
Author

Stupid question: would it find anything else? Is a player connected?

Everything is OK but the quick search.
"Quick search" means when you type a keyword,system will lookup library and return a list of songs and albums whose meta information contain the keyword.Just like this:
Screenshot_2022-12-29-21-22-01-77_82b10d9f3584360f08225ddcebbb4f6d

You get nothing when using Chinese Keyword in quick search:
Screenshot_2022-12-29-21-22-29-19_82b10d9f3584360f08225ddcebbb4f6d

Use the same Chinese Keyword in advance search,correct result return:
Screenshot_2022-12-29-21-24-24-15_82b10d9f3584360f08225ddcebbb4f6d
Screenshot_2022-12-29-21-24-45-35_82b10d9f3584360f08225ddcebbb4f6d

@michaelherger
Copy link
Member

You mention an update to Daphile: did it work before that update?

And you're using the Material skin. Would you see the same behavior using the Default skin?

@silenker
Copy link
Author

You mention an update to Daphile: did it work before that update?

And you're using the Material skin. Would you see the same behavior using the Default skin?

There's no such problem before,and nothing business with the skin.I tried:
Screenshot_2022-12-30-18-17-44-42_82b10d9f3584360f08225ddcebbb4f6d
Screenshot_2022-12-30-18-18-57-56_82b10d9f3584360f08225ddcebbb4f6d

@silenker silenker closed this as completed Jan 1, 2023
@silenker
Copy link
Author

silenker commented Jan 1, 2023

I fixed this problem by disable the "Full text search" plugin. Thanks

@michaelherger
Copy link
Member

Oh, thanks for that finding! I should probably re-open this report! It is a bug, after all.

@mherger mherger self-assigned this Jan 1, 2023
@mherger mherger added the bug label Jan 1, 2023
@mherger mherger reopened this Jan 1, 2023
@mherger mherger changed the title No result return while using Chinese Keyword in Quick search No result return while using Chinese Keyword in Fulltext Search Jan 1, 2023
@michaelherger
Copy link
Member

We might need to define tokenizer=unicode61 or similar (see https://www.sqlite.org/fts5.html#_changes_to_create_virtual_table_statements_).

@michaelherger
Copy link
Member

Unfortunately tokenizer=unicode61 isn't available in our builds of the SQLite/FTS libraries.

Rather surprising: Cyrillic titles work as expected.

@silenker
Copy link
Author

silenker commented Jan 2, 2023

We might need to define tokenizer=unicode61 or similar (see https://www.sqlite.org/fts5.html#_changes_to_create_virtual_table_statements_).

That might be the root cause,Thank you for your quick response

@michaelherger
Copy link
Member

The issue actually is caused by a change in 8.3.0 which tries to de-duplicate keywords in the full text search. This fails for certain languages.

@mherger mherger closed this as completed in 353c504 Jan 4, 2023
mherger added a commit that referenced this issue Jan 4, 2023
* public/8.3:
  Fix #852 - Don't try to de-duplicate strings for certain languages
@michaelherger
Copy link
Member

@kimmot - can you upgrade Daphile to the latest 8.3.1?

@kimmot
Copy link
Contributor

kimmot commented Jan 4, 2023

New Daphile version 23.01 is now available and it includes the latest 8.3.1 (commit: 353c504).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants