Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

album in favorites not browsable #918

Closed
grasshide opened this issue Oct 12, 2023 · 6 comments
Closed

album in favorites not browsable #918

grasshide opened this issue Oct 12, 2023 · 6 comments
Labels

Comments

@grasshide
Copy link

I use the latest lms docker stable (Version: 8.3.2).
When I add a music album to favorites it shows up in the favorites section. But the only option I have there is to play the complete album.
I expected to be able to click on the album to see its contents to play single songs. Instead, when I click the album a page opens printing the string "Empty".

@michaelherger
Copy link
Member

I‘m not near a LMS. But isn’t there an option to enable the drilling down? Settings/Advanced/Favorites or the like?

@grasshide
Copy link
Author

I didn't know that this was optional. But it is set to "when you select [...] drill down on its content".
The behavior is very different:

  • selecting a spotify playlist, it actually lists the songs of the playlist
  • selecting a local playlist it only brings up the playlist icon along with the playlist title and url
  • selecting an album a page with the string "Empty" is shown

@michaelherger
Copy link
Member

Would you mind sharing your favorites.opml file (from the prefs or playlist folder - see Settings/Information) and the library.db (from the cache folder) with me? https://www.dropbox.com/request/T3RctyzGgNg0oFDubq6a

@mherger mherger added the bug label Oct 13, 2023
@mherger
Copy link
Contributor

mherger commented Oct 13, 2023

Thanks for the files! That's a bug indeed. I'll have to figure out what happened here.

@mherger
Copy link
Contributor

mherger commented Oct 27, 2023

Wow... that was a major WTF?!? moment... I was wondering why I and others wouldn't see this issue. Yet with your data I was clearly able to reproduce it. So I did my homework and (hopefully) fixed it. And then I wanted to merge from 8.3 to 8.4 and received a merging conflict. Because I already had fixed this in 8.4 and didn't remember it!... Argh... 😠

@mherger mherger closed this as completed Oct 27, 2023
@grasshide
Copy link
Author

Urgh, sh*t. Sorry that this ate up so much of your time!
I'm glad that there is a fix on the way though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants