Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLV support in derive macro may lead to invalid serialization #1

Open
dr-orlovsky opened this issue Jan 17, 2023 · 0 comments
Open

TLV support in derive macro may lead to invalid serialization #1

dr-orlovsky opened this issue Jan 17, 2023 · 0 comments
Labels
bug Something isn't working question Further information is requested

Comments

@dr-orlovsky
Copy link
Contributor

TLV stream has to be the last data item in any message. This wouldn't be the case if a message has fields which are in turn structures with TLV fields, as was discovered by @crisdut in LNP-WG/lnp-node#66

Derive macro has somehow to prevent that from happening (not clear how though...).
@dr-orlovsky dr-orlovsky added bug Something isn't working question Further information is requested labels Jan 17, 2023
@dr-orlovsky dr-orlovsky mentioned this issue Jan 17, 2023
Merged
@dr-orlovsky dr-orlovsky mentioned this issue Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dr-orlovsky