Store msclInternalNode as a std::unique_ptr<mscl::InertialNode> #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable from diagnostic updater Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
allenh1
force-pushed
the
store-mscl-as-unique-ptr
branch
from
b8dd18b
to
4f92d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the mscl::InertialNode as a std::unique_ptr, and remove unused variable from diagnostic updater
Signed-off-by: Hunter L. Allen hunter.allen@ghostrobotics.io
The original implementation makes a pointer to a stack object which it uses throughout the class. It's probably safer to heap allocate the node and store it as a
std::unique_ptr.