Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS Ntrip Version Configuration #8

Merged
merged 4 commits into from Apr 22, 2022
Merged

ROS Ntrip Version Configuration #8

merged 4 commits into from Apr 22, 2022

Conversation

robbiefish
Copy link
Contributor

  • No longer sends an Ntrip-Version header with no value
  • Allows the user to specify an ntrip_version which will be sent as the Ntrip-Version header value

msclissa
msclissa requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@msclissa msclissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If request fails and the NTRIP version is not specified it might be nice to suggest that may be the cause - error message from the caster may be unclear.

@robbiefish robbiefish requested a review from msclissa April 4, 2022 17:35
@robbiefish robbiefish merged commit 11bd0b9 into ros Apr 22, 2022
@robbiefish robbiefish deleted the feature/ros_ntrip_version branch July 19, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msclissa msclissa msclissa approved these changes

@dacuster dacuster Awaiting requested review from dacuster

Assignees

@dacuster dacuster

@msclissa msclissa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robbiefish @msclissa @dacuster