Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download link missing from gene homepage for public, even if setting is enabled #175

Closed
ifokkema opened this issue Jan 19, 2017 · 4 comments
Assignees
Milestone

Comments

@ifokkema
Copy link
Member

The download link for the public, allowing a non-authorized user to download the full gene data (individuals, phenotypes, screenings, variants), is missing from the gene homepage, even if the curator has enabled this option.
When the curator enabled this option, the download link should be available and the download should contain all public data from this gene. Non-public columns should be removed.

@ifokkema ifokkema added this to the 3.0 Build 19 milestone Jan 19, 2017
@ifokkema
Copy link
Member Author

Duplicate of #78.

@mkroon1
Copy link
Collaborator

mkroon1 commented Jan 31, 2017

Most of export functionality already exists in download.php. On the gene homepage we can link to /download/all/gene/NAME, and modify download.php to check if the download flag for the gene is set and filter non-public columns and records if needed.

@mkroon1
Copy link
Collaborator

mkroon1 commented Jan 31, 2017

Btw, this issue is marked as a duplicate, but it's still linked to the project for the next milestone. Is this the place to discuss progress?

@ifokkema
Copy link
Member Author

ifokkema commented Feb 1, 2017

Main issue is #78 😉

@mkroon1 mkroon1 moved this from TODO to In Progress in Milestone 3.0-19 Feb 8, 2017
@mkroon1 mkroon1 self-assigned this Feb 13, 2017
@mkroon1 mkroon1 moved this from In Progress to To Be Reviewed in Milestone 3.0-19 Feb 13, 2017
@ifokkema ifokkema moved this from To Be Reviewed to Done in Milestone 3.0-19 Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants