Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the summary annotation record feature from LOVD+ and extend functionality #349

Open
7 of 16 tasks
ifokkema opened this issue Mar 28, 2018 · 0 comments
Open
7 of 16 tasks
Assignees

Comments

@ifokkema
Copy link
Member

ifokkema commented Mar 28, 2018

LOVD+ has a feature called Summary Annotation Record, where each unique variant can have one (and one only) record summarizing information from all observations of this variant. By default, this contains the variant's effect, but it's a custom object and can, therefore, be extended with custom columns.

This Summary Annotation Record should then be used to make the life of the curator a bit easier and should copy the curator's variant effect value to all new observations of the variant.

Tasks:

Building the feature:

  • Decide on how to link - LOVD+'s method of linking is more stable for variants that don't change, but not currently compatible with LOVD3. LOVD's method of linking is flexible but is not stable in case a variant gets deleted and recreated, which may happen frequently. Also, when hg38 comes, you don't want to be unclear about which build has the ID (and what of variants that don't have a description under a certain build?).
  • Copy the Summary Annotation Record feature from LOVD+.
    • Table setup
      • Enforce key on the DBID column? Depends on linking strategy as well.
    • Custom column setup
    • Viewing the record
    • Adding the record
    • Editing the record
  • Setup up some basic custom columns
    • Variant effect - Store reported/concluded or only concluded?

Integration with LOVD3:

  • Auto generate Summary Annotation Records upon curation of variant?
  • Have the record itself mention conflicts in the concluded variant effect?
    • Have the record fix this with one click?
  • Have new submissions copy the concluded effect from the SAR?
    • At what stage? Submission? Curation?
  • Prevent updating a DBID when there's a SAR?
@ifokkema ifokkema added this to the 3.0 Build 22 milestone Mar 28, 2018
@ifokkema ifokkema added this to To do in Milestone 3.0-22 via automation Mar 28, 2018
@ifokkema ifokkema added this to To do in Milestone 3.0-23 via automation Jul 30, 2019
@ifokkema ifokkema removed this from To do in Milestone 3.0-22 Jul 30, 2019
@ifokkema ifokkema modified the milestones: 3.0 Build 22, 3.0 Build 23 Jul 30, 2019
@ifokkema ifokkema self-assigned this Dec 19, 2019
@ifokkema ifokkema removed this from To do in Milestone 3.0-23 Feb 10, 2020
@ifokkema ifokkema added this to To do in Milestone 3.0-24 via automation Feb 10, 2020
@ifokkema ifokkema modified the milestones: 3.0 Build 23, 3.0 Build 24 Feb 10, 2020
@ifokkema ifokkema modified the milestones: 3.0 Build 24, 3.0 Build 25 Jul 13, 2020
@ifokkema ifokkema removed this from To do in Milestone 3.0-24 Jul 13, 2020
@ifokkema ifokkema added this to To do in Release 3.0-25 via automation Jul 13, 2020
@ifokkema ifokkema removed this from To do in Release 3.0-25 Oct 21, 2020
@ifokkema ifokkema added this to To do in Release 3.0-26 via automation Oct 21, 2020
@ifokkema ifokkema modified the milestones: 3.0 Build 25, 3.0 Build 26 Oct 21, 2020
@ifokkema ifokkema removed this from To do in Release 3.0-26 Feb 22, 2021
@ifokkema ifokkema added this to To do in Release 3.0-27 via automation Feb 22, 2021
@ifokkema ifokkema modified the milestones: 3.0 Build 26, 3.0 Build 27 Feb 22, 2021
@ifokkema ifokkema removed this from To do in Release 3.0-27 Aug 16, 2021
@ifokkema ifokkema added this to To do in Release 3.0-28 via automation Aug 16, 2021
@ifokkema ifokkema modified the milestones: 3.0 Build 27, 3.0 Build 28 Aug 16, 2021
@ifokkema ifokkema removed this from To do in Release 3.0-28 Jul 11, 2022
@ifokkema ifokkema removed this from the 3.0 Build 28 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant