Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect PE bitness detection. #5

Open
sredna opened this issue Feb 26, 2022 · 1 comment
Open

Incorrect PE bitness detection. #5

sredna opened this issue Feb 26, 2022 · 1 comment

Comments

@sredna
Copy link

sredna commented Feb 26, 2022

You should not be comparing the machine type with IMAGE_FILE_MACHINE_I386 to find out if it is 32 or 64 bit, you should check the Magic member of IMAGE_OPTIONAL_HEADER. The current code would fail on 32-bit ARM files and old rare stuff like Alpha and Power PC.
@LRN
Copy link
Owner

LRN commented Feb 26, 2022 •
edited

I'm not actively maintaining this program, but i'll gladly merge a well-put pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LRN @sredna