Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of BaccoEmu Baryons object #1125

Closed
damonge opened this issue Sep 28, 2023 · 3 comments · Fixed by #1172
Closed

Inconsistent naming of BaccoEmu Baryons object #1125

damonge opened this issue Sep 28, 2023 · 3 comments · Fixed by #1172
Assignees
@zdu863
Labels
API Difficulty: Easy

Comments

@damonge
Copy link
Collaborator

damonge commented Sep 28, 2023

The BaccoemuBaryons object should be called BaryonsBaccoemu to conform with the naming of other baryonic effect objects (e.g. BaryonsSchneider15 or BaryonsVanDaalen19).

Unfortunately this slipped through after tagging v3, and changing it would break the API. Thoughts?
@damonge
Copy link
Collaborator Author

damonge commented Sep 28, 2023

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

@nikosarcevic
Copy link
Contributor

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

I would suggest naming it "BaryonsArico20" to keep consistent with other modules.

@zdu863 zdu863 self-assigned this Mar 18, 2024
@zdu863 zdu863 linked a pull request Mar 27, 2024 that will close this issue
Inconsistent naming of baccoemu baryons object #1172
Merged
@zdu863
Copy link
Contributor

zdu863 commented Mar 27, 2024

The solution should be to rename a BaccoemuBaryons into BaryonsBaccoemu, and create a class called BaccoemuBaryons that inherits from it and simply throws a deprecation warning if initialised.

Do we need to create separate unit tests for the deprecated class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdu863 zdu863

Labels
API Difficulty: Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistent naming of baccoemu baryons object LSSTDESC/CCL
3 participants
@damonge @nikosarcevic @zdu863