Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEDs to readiness test #64

Closed
evevkovacs opened this issue Jan 23, 2018 · 2 comments · Fixed by #66
Closed

Add SEDs to readiness test #64

evevkovacs opened this issue Jan 23, 2018 · 2 comments · Fixed by #66

Comments

@evevkovacs
Copy link
Contributor

@yymao Please take a look at https://github.com/evevkovacs/descqa/blob/ready_SEDS/SED_test.ipynb
The distributions are not as unreasonable looking as I expected, if we convert the SEDs to magnitudes. I am thinking that we can add a keyword to the yaml file such as function: -2.5*np.log10, which tells the readiness test to first evaluate the function on the catalog data before plotting it or computing any other statistics. What do you think?

@yymao
Copy link
Member

yymao commented Jan 23, 2018

@evevkovacs the current readiness has the option to plot and calculate the statistics of the quality after taking log. I know log luminosity is not magnitude but they differ by only a constant factor. Given that this test is just for bug finding, I think this would be good enough, no?

@evevkovacs
Copy link
Contributor Author

Yes, that would be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants