Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointEstimateMixin overwrites existing ancil data #82

Closed
drewoldag opened this issue Jan 17, 2024 · 0 comments · Fixed by #83
Closed

PointEstimateMixin overwrites existing ancil data #82

drewoldag opened this issue Jan 17, 2024 · 0 comments · Fixed by #83
Assignees
Labels
bug Something isn't working

Comments

@drewoldag
Copy link
Collaborator

Bug report
Calling PointEstimateMixin.calculate_point_estimates will overwrite existing ancil data. This is because we're using .set_ancil instead of .add_to_ancil.

The solution here would be something like:

if qp_dist.ancil is None:
    qp_dist.set_ancil(ancil_dict)
else:
    qp_dist.add_to_ancil(ancil_dict)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant