Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows binary produced via cross-compilation consumes all system memory. #18

Closed
goldsam opened this issue Aug 13, 2023 · 2 comments
Closed

Comments

@goldsam
Copy link

goldsam commented Aug 13, 2023

@LSViana I'm seeing memory consumption grow without bound for some of the map-related tests (InsertMap for example) on windows x64. Could you take a look at my github workflow. I'm current doing a cross-compilation when maybe building on windows might be the best approach.

I'm also patching the yffi/Cargo.toml to produce a dynamic library. What was your approach to building your local binary assets?

@goldsam
Copy link
Author

goldsam commented Aug 14, 2023

This is cleared up by #19 which references custom yrs build

@goldsam goldsam closed this as completed Aug 14, 2023
@LSViana
Copy link
Collaborator

LSViana commented Aug 14, 2023

@goldsam Just to give you some extra details for your mentions here:

I'm seeing memory consumption grow without bound for some of the map-related tests (InsertMap for example) on windows x64.

It's possible that there are some memory leaks in some operations, I have plans to check these once I'm done creating all bindings.

I'm also patching the yffi/Cargo.toml to produce a dynamic library.

Yes, that's what I'm doing currently as well. However, I'll look into the Cargo CLI options later to verify if it's possible to specify the crate-type through the commands so the main repository doesn't have to change.

But this, just like the issue mentioned above, will be focused only after the bindings are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants