Files are read twice even if no patterns are given

[fabianegli]

The below code will open files and loop through them regardless of the presence of patterns to match against.

I propose to make the file opening conditional based on the presence of patterns.

pytest-workflow/src/pytest_workflow/content_tests.py

Lines 147 to 156 in ef7f312

	# Use 'rt' here explicitly as opposed to 'rb'
	with file_open(mode='rt') as file_handler: # type: ignore # mypy goes crazy here otherwise # noqa: E501
	self.found_strings = check_content(
	strings=strings_to_check,
	text_lines=file_handler)
	# Read the file again for the regex
	with file_open(mode='rt') as file_handler: # type: ignore # mypy goes crazy here otherwise # noqa: E501
	self.found_patterns = check_regex_content(
	patterns=patterns_to_check,
	text_lines=file_handler)

e.g:

            if strings_to_check:
                with file_open(mode='rt') as file_handler:  # type: ignore  # mypy goes crazy here otherwise  # noqa: E501
                    self.found_strings = check_content(
                        strings=strings_to_check,
                        text_lines=file_handler)
            if patterns_to_check:
                with file_open(mode='rt') as file_handler:  # type: ignore  # mypy goes crazy here otherwise  # noqa: E501
                    self.found_patterns = check_regex_content(
                        patterns=patterns_to_check,
                        text_lines=file_handler)

[rhpvorderman]

Good find. I will see if I can fix this before the next release.

[rhpvorderman]

I did a double check. While the files are opened, due to the nature of the iterator the file is not read when there are no patterns.
Even so it is a shame to read the file twice when there are both regexes and strings so that is also fixed now.