Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault with python 3.9 #74

Closed
billbrod opened this issue Jan 8, 2021 · 2 comments · Fixed by #184
Closed

Segfault with python 3.9 #74

billbrod opened this issue Jan 8, 2021 · 2 comments · Fixed by #184
Labels
bug Something isn't working

Comments

@billbrod
Copy link
Member

billbrod commented Jan 8, 2021

We're running into segfaults on python 3.9, which looks like it's a pytorch issue. In our code, It looks like it happens whenever .synthesize() is called, and, looking at the pytorch issue, that's because of .backward().

Minimum example:

import torch; import plenoptic as po
im = torch.randn((1, 1, 256, 256), requires_grad=True)
v1 = po.simul.PooledV1(.5, im.shape[-2:])
v1(im).sum().backward()

It looks like everything works fine, but then when you quit, you should get a message that the process was terminal by signal SIGSEGV or something that similarly tells you there was a segfault.

@billbrod billbrod added the bug Something isn't working label Jan 8, 2021
@billbrod
Copy link
Member Author

billbrod commented Jan 8, 2021

So I think we keep an eye on it?

@billbrod
Copy link
Member Author

Looks like it's fixed now, should be able to get this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant