Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbDisc, Refactor Plate Cache, cache custom props #4673

Open
15 tasks done
labkey-klum opened this issue Aug 15, 2023 · 0 comments · Fixed by #4694
Open
15 tasks done

AbDisc, Refactor Plate Cache, cache custom props #4673

labkey-klum opened this issue Aug 15, 2023 · 0 comments · Fixed by #4694
Assignees

Comments

@labkey-klum
Copy link
Contributor

labkey-klum commented Aug 15, 2023

spec

Rationale
In order to reduce the number of queries we have to make for the Antibody Discovery MVP scenarios we want to try to push more information that can be cached. This includes well and potentially well metadata.

One thing that needs to be refactored is that currently the cache is scoped at the container level so when a plate is changed all plates will need to be re-queried. We want to change the cache to per-plate granularity, but one thing that complicates this is that we currently reference plates by:

  • name
  • lsid
  • rowId
    This makes it more complicated since a BlockingCache key is a single object.

Tasks

  • Cache at the per plate scope
    • Implement cache key for name, lsid, rowid : 3
    • Implement internal cache maps : 3
    • serialize/deserialize cache key : 3
    • Update endpoints : 2
    • Implement cache removals : 3
    • Use the plate cache where possible : 3
  • Additional objects to cache
    • Plate custom fields : 3
    • Metadata domain : 2
    • Ensure creation of metadata domain for Biologics folders (with experimental flag) : 3
  • Move app plate experimental flag to assay module : 1
  • Update via Data Iterator not working for vocab properties : 3
  • Plate metadata unit tests : 3
  • Remove well metadata endpoints : 2
@labkey-klum labkey-klum self-assigned this Aug 15, 2023
@labkey-klum labkey-klum linked a pull request Aug 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant