Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging and dropping modules expands irrelevant trees. #332

Open
theSloopJohnB opened this issue Jul 18, 2017 · 1 comment
Open

Dragging and dropping modules expands irrelevant trees. #332

theSloopJohnB opened this issue Jul 18, 2017 · 1 comment
Labels

Comments

@theSloopJohnB
Copy link
Contributor

If you drag a module from one engine to another, and you have a third collapsed tree in between, the collapsed tree will open when you drop the module.

See gif for details.

tree-expansion

@becega
Copy link
Contributor

becega commented Jul 18, 2017

The repo is not storing the state ( open or closed) of the tree (VIEW). When we are dragging and dropping we are actually moving the nodes inside of the repo hierarchy array and then refreshing the tree (VIEW) . As the tree is "refreshed", it goes to the default state that is all nodes are open.
In order to add this functionality, we need to update CEF. The changes required will be:

  • Add an extra property to the node (state open or close)
  • Add code to update this property. This will be required in both of the main editor templates in CEF and also update in the editor in DCAF. The change will be add a event handle to the open and close event which then will store this information in the node.
  • Update the RefreshEntireTreeWithGlyphManager.vi to call the closed method for all the nodes that were closed.

You will see similar behavior if you collapse the tree save it and load it. the close state is not preserved. In order to also add this functionality we will also need to save the state to the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants