Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No thumbs request when size="hidden" #23

Closed
mjh1709muc opened this issue Mar 8, 2016 · 3 comments
Closed

No thumbs request when size="hidden" #23

mjh1709muc opened this issue Mar 8, 2016 · 3 comments
Assignees

Comments

@mjh1709muc
Copy link
Contributor

@@ -62,7 +62,9 @@ function credit_tracker_table_shortcode($atts)
    $images = credittracker_get_images($request);

    $ret = '<table id="credit-tracker-table" class="credit-tracker-' . $style . '"><thead>';
    $ret .= '<th>' . '&nbsp;' . '</th>';
    if ($size != 'hidden') {
        $ret .= '<th>' . '&nbsp;' . '</th>';
    }

    foreach ($columns as $column) {
        if (!empty($column)) {
@@ -86,7 +88,9 @@ function credit_tracker_table_shortcode($atts)
                $ct_copyright_format = credittracker_get_single_option('ct_copyright_format');
            }
            $ret .= '<tr>';
            $ret .= '<td>' . '<img width="' . $image['width'] . '" height="' . $image['height'] . '" src="' . $image['url'] . '" class="attachment-thumbnail" alt="' . $image['alt'] . '">' . '</td>';
            if ($size != 'hidden') {
              $ret .= '<td>' . '<img width="' . $image['width'] . '" height="' . $image['height'] . '" src="' . $image['url'] . '" class="attachment-thumbnail" alt="' . $image['alt'] . '">' . '</td>';
            }
            foreach ($columns as $column) {
                if (!empty($column)) {
                    if ($column == 'copyright') {
@r-brown r-brown self-assigned this Mar 8, 2016
@r-brown
Copy link
Member

r-brown commented Mar 8, 2016

Hello @mjh1709muc , in case this issue is a change request for the credit-tracker, I'd ask you to create a pull request. This will simplify merge.

@mjh1709muc
Copy link
Contributor Author

Hi. Thanks for your quick reply. I am not able to make a pull request because of missing permissions!
I have another fix - so could you give me permissions?

@r-brown
Copy link
Member

r-brown commented Mar 9, 2016

Hi, this not about permissions; generally, everybody can create a pull request. You need only fork credit tracker repo, made changes in your copy, push those and then you'll be able create pull request via GitHub UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants